Configurable startup timeout for supervisor; better exit detection #10042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
sharon-wang
reviewed
Oct 22, 2025
|
|
||
| // ECONNREFUSED (for TCP) and ENOENT (for sockets) are normal | ||
| // conditions during startup; the server isn't ready yet. Keep | ||
| // trying up to 10 seconds from the time we got a process ID |
There was a problem hiding this comment.
There are a few places where "10 seconds" is referenced, including an error message Timed out waiting for connection file to be ` + `created at ${connectionFile} after 10 seconds Shall we change this to "startupTimeout seconds"?
There was a problem hiding this comment.
Oh thanks, I should have fixed those up! Addressed in 96ec61f.
| // Consult configuration to see if we should show this terminal | ||
| const config = vscode.workspace.getConfiguration('kernelSupervisor'); | ||
| const showTerminal = config.get<boolean>('showTerminal', false); | ||
| const startupTimeout = config.get<number>('startupTimeout', 10) * 1000; |
There was a problem hiding this comment.
Would it be useful to log these config settings to the output pane?
There was a problem hiding this comment.
Yes! Done in 96ec61f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change does not fix any known problems, but is intended to help us get better diagnostics on issues like #8000 wherein the supervisor appears to be timing out at startup. Specifically, it seems possible that the supervisor is actually exited in these cases or is taking extra long to start, so: